Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: structured log handler formatting issues #319

Merged
merged 9 commits into from Jun 10, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Jun 8, 2021

This PR fixes a number of formatting edge cases around the StructuredLogHandler:

  • format strings were not handled properly, with arguments dropped (#313)
  • line breaks would break the log formatting, preventing it from being parsed properly (#318)
  • custom log formatters could not be applied without breaking the fianl GCP formatting (#314)

Fixes #314, #318, #313 馃

@daniel-sanche daniel-sanche requested review from as code owners Jun 8, 2021
@product-auto-label product-auto-label bot added the api: logging label Jun 8, 2021
@google-cla google-cla bot added the cla: yes label Jun 8, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Jun 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 9, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Jun 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 9, 2021
@daniel-sanche daniel-sanche changed the title [DRAFT] fix: structured log handler formatting issues fix: structured log handler formatting issues Jun 10, 2021
@daniel-sanche daniel-sanche merged commit db9da37 into master Jun 10, 2021
14 of 17 checks passed
@daniel-sanche daniel-sanche deleted the fix-structured-log-format branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants