Skip to content
This repository was archived by the owner on Feb 26, 2026. It is now read-only.

feat: added support for iam AuditData proto#396

Merged
daniel-sanche merged 9 commits into
mainfrom
audit-data-2
Oct 5, 2021
Merged

feat: added support for iam AuditData proto#396
daniel-sanche merged 9 commits into
mainfrom
audit-data-2

Conversation

@daniel-sanche

@daniel-sanche daniel-sanche commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

We previously added support for AuditLog and RequestLog protos in v2.5.0. This PR also adds support for google.iam.v1.logging.AuditData by importing the google-cloud-iam-logging dependency

Fixes #363 🦕

@daniel-sanche daniel-sanche requested review from a team September 14, 2021 22:37
@product-auto-label product-auto-label Bot added the api: logging Issues related to the googleapis/python-logging API. label Sep 14, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2021

@losalex losalex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche daniel-sanche merged commit e3a1eba into main Oct 5, 2021
@daniel-sanche daniel-sanche deleted the audit-data-2 branch October 5, 2021 23:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

entry.to_api_repr() causes exception Can not find message descriptor by type_url: type.googleapis.com/google.iam.v1.logging.AuditData

2 participants