Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use structured logging on GCF with python 3.7 #434

Merged
merged 8 commits into from Nov 1, 2021
Merged

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Oct 27, 2021

Previously, GCF Python 3.7 didn't support structured logging, so the library would default to the grpc CloudLoggingHandler. now that the environment supports structured logging, we can update to the StructuredLoggingHandler to make it in line with other serverless environments

@daniel-sanche daniel-sanche requested review from as code owners Oct 27, 2021
@product-auto-label product-auto-label bot added the api: logging label Oct 27, 2021
@google-cla google-cla bot added the cla: yes label Oct 27, 2021
Copy link
Contributor

@losalex losalex left a comment

LGTM

@daniel-sanche daniel-sanche changed the title feat: use structured logging on GCF with python 3.7 [DRAFT] feat: use structured logging on GCF with python 3.7 Oct 27, 2021
@daniel-sanche
Copy link
Contributor Author

@daniel-sanche daniel-sanche commented Oct 27, 2021

It looks like the environment still isn't working with structured logging. I'm going to hold this open as a draft for now

@daniel-sanche daniel-sanche changed the title [DRAFT] feat: use structured logging on GCF with python 3.7 feat: use structured logging on GCF with python 3.7 Oct 29, 2021
losalex
losalex approved these changes Nov 1, 2021
Copy link
Contributor

@losalex losalex left a comment

LGTM

@daniel-sanche daniel-sanche merged commit 5055919 into main Nov 1, 2021
19 of 20 checks passed
@daniel-sanche daniel-sanche deleted the functions-37 branch Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants