Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve docs #77

merged 19 commits into from Oct 27, 2020

fix: improve docs #77

merged 19 commits into from Oct 27, 2020


Copy link

@daniel-sanche daniel-sanche commented Oct 19, 2020

The generated docs on are miseading. They advertise two versions of the API, when we actually only publish v2. It also makes it seem like the autogenerated library is the newer version and the handwritten layer is deprecated

This PR:

  • removed the autogenerated layer from the generated documentation at
  • removed the misleading v1 version from
  • improved the code samples on the README to use the hand-written layer instead of autogenerated code
  • changed branding in the docs from Stackdriver Logging to Cloud Logging and Container Engine to Kubernetes Engine
  • got the Kokoro docs-presubmit check to turn green

This should greatly reduce customer confusion

Fixes ##76 馃

@google-cla google-cla bot added the cla: yes label Oct 19, 2020
@daniel-sanche daniel-sanche marked this pull request as ready for review Oct 20, 2020
@daniel-sanche daniel-sanche requested a review from as a code owner Oct 20, 2020
@simonz130 simonz130 added type: docs api: logging lang: python labels Oct 26, 2020 Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@daniel-sanche daniel-sanche requested a review from as a code owner Oct 27, 2020
@daniel-sanche daniel-sanche requested a review from busunkim96 Oct 27, 2020
@daniel-sanche daniel-sanche merged commit bdd9c44 into googleapis:master Oct 27, 2020
9 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 19, 2020
馃 I have created a release \*beep\* \*boop\* 
## [2.0.0]( (2020-11-19)


* Use microgenerator for GAPIC layer. See []( for details. (#94)
* removes support for webapp2 and other Python2 specific code

### Features

* pass 'client_options' to super ctor ([#61]( ([c4387b3](, closes [#55](
* use microgenerator ([#94]( ([ff90fd2](

### Bug Fixes

* add default filter settings to list_entries ([#73]( ([0a1dd94](
* failing CI tests ([#70]( ([96adeed](

### Code Refactoring

* remove python2 ([#78]( ([bf579e4](

### Documentation

* update docs ([#77]( ([bdd9c44](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: logging cla: yes lang: python type: docs
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants