Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use microgenerator #94

merged 4 commits into from Nov 19, 2020

feat!: use microgenerator #94

merged 4 commits into from Nov 19, 2020


Copy link

@busunkim96 busunkim96 commented Nov 17, 2020

Changes reviewed in #83, #89, and #92 being moved to main branch.

@busunkim96 busunkim96 requested review from as code owners Nov 17, 2020
@busunkim96 busunkim96 requested a review from tmatsuo Nov 17, 2020
@product-auto-label product-auto-label bot added the api: logging label Nov 17, 2020
@google-cla google-cla bot added the cla: yes label Nov 17, 2020
@busunkim96 busunkim96 changed the title Microgen feat!: use microgenerator Nov 17, 2020
busunkim96 added 3 commits Nov 17, 2020
The bulk of the changes are to the handwritten code (`gogle/cloud/logging_v2/*.py`). Changes are listed in ``.

* `_gapic` uses the microgenerated surface
* Add support for parent resources that are not `project` (`folder`, `billingAccount`, `organization`) where appropriate for log entries and sinks.
* Use google-style docstrings
* Optional params can only be passed as kwargs
Copy link

@tmatsuo tmatsuo commented Nov 18, 2020

Can we make the samples test mandatory?

@busunkim96 busunkim96 merged commit ff90fd2 into master Nov 19, 2020
9 checks passed
@busunkim96 busunkim96 deleted the microgen branch Nov 19, 2020
@release-please release-please bot mentioned this pull request Nov 19, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 19, 2020
🤖 I have created a release \*beep\* \*boop\* 
## [2.0.0]( (2020-11-19)


* Use microgenerator for GAPIC layer. See []( for details. (#94)
* removes support for webapp2 and other Python2 specific code

### Features

* pass 'client_options' to super ctor ([#61]( ([c4387b3](, closes [#55](
* use microgenerator ([#94]( ([ff90fd2](

### Bug Fixes

* add default filter settings to list_entries ([#73]( ([0a1dd94](
* failing CI tests ([#70]( ([96adeed](

### Code Refactoring

* remove python2 ([#78]( ([bf579e4](

### Documentation

* update docs ([#77]( ([bdd9c44](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: logging cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants