Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

feat!: move to use microgen #54

Merged
merged 4 commits into from
Oct 6, 2020
Merged

feat!: move to use microgen #54

merged 4 commits into from
Oct 6, 2020

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Oct 3, 2020

Please pay special attention to

  1. synth hack in synth.py
  2. changes to handwritten file google/cloud/monitoring_v3/query.py

@arithmetic1728 arithmetic1728 requested review from a team as code owners October 3, 2020 06:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2020
Copy link

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nits in query.py and synth.py

google/cloud/monitoring_v3/query.py Outdated Show resolved Hide resolved
google/cloud/monitoring_v3/query.py Outdated Show resolved Hide resolved
google/cloud/monitoring_v3/query.py Outdated Show resolved Hide resolved
google/cloud/monitoring_v3/query.py Outdated Show resolved Hide resolved
google/cloud/monitoring_v3/query.py Outdated Show resolved Hide resolved
synth.py Show resolved Hide resolved
synth.py Show resolved Hide resolved
google/cloud/monitoring_v3/query.py Outdated Show resolved Hide resolved
google/cloud/monitoring_v3/query.py Outdated Show resolved Hide resolved
arithmetic1728 and others added 2 commits October 6, 2020 11:46
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@arithmetic1728 arithmetic1728 merged commit d25e49f into master Oct 6, 2020
@arithmetic1728 arithmetic1728 deleted the migrate branch October 6, 2020 19:11
@release-please release-please bot mentioned this pull request Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants