Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

feat: Adding labels to the metric descriptor in the snippets.py #88

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

vinbs
Copy link
Contributor

@vinbs vinbs commented Mar 2, 2021

This helps understand how to add labels for custom metrics [1].

[1] https://cloud.google.com/monitoring/custom-metrics/creating-metrics#create-metric-desc

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #86 馃

@vinbs vinbs requested a review from a team as a code owner March 2, 2021 19:24
@vinbs vinbs requested a review from busunkim96 March 2, 2021 19:24
@product-auto-label product-auto-label bot added the api: monitoring Issues related to the googleapis/python-monitoring API. label Mar 2, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2021
@busunkim96 busunkim96 added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Mar 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 811f9aa into googleapis:master Mar 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: monitoring Issues related to the googleapis/python-monitoring API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding labels to the metric descriptor in the snippets.py
3 participants