Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix: flaky samples tests (#263)
* chore: turn off type hints

* fix: try get instead of delete
  • Loading branch information
anguillanneuf committed Dec 21, 2020
1 parent 8eed8e1 commit 3d6a29d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion samples/snippets/noxfile_config.py
Expand Up @@ -25,7 +25,7 @@
"ignored_versions": ["2.7"],
# Old samples are opted out of enforcing Python type hints
# All new samples should feature them
"enforce_type_hints": True,
"enforce_type_hints": False,
# An envvar key for determining the project id to use. Change it
# to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
# build specific Cloud project. You can also use your own string
Expand Down
2 changes: 1 addition & 1 deletion samples/snippets/subscriber_test.py
Expand Up @@ -145,7 +145,7 @@ def subscription_dlq(subscriber_client, topic, dead_letter_topic):
)

try:
subscription = subscriber_client.delete_subscription(
subscription = subscriber_client.get_subscription(
request={"subscription": subscription_path}
)
except NotFound:
Expand Down

0 comments on commit 3d6a29d

Please sign in to comment.