Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain how to nack a sync pull message #123

Merged
merged 2 commits into from Jun 18, 2020
Merged

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jun 15, 2020

Closes #122.

This PR adds a short explanation on how to NACK sync pull messages.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from pradn Jun 15, 2020
pradn
pradn approved these changes Jun 17, 2020
docs/subscriber/index.rst Outdated Show resolved Hide resolved
Loading
docs/subscriber/index.rst Outdated Show resolved Hide resolved
Loading
@plamut plamut requested a review from pradn Jun 18, 2020
pradn
pradn approved these changes Jun 18, 2020
@pradn pradn merged commit f2eec65 into googleapis:master Jun 18, 2020
3 checks passed
Loading
@plamut plamut deleted the iss-122 branch Jun 19, 2020
sethmaxwl added a commit to sethmaxwl/python-pubsub that referenced this issue Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants