Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make fixup script consistent with migration docs #208

Merged
merged 4 commits into from Oct 13, 2020

Conversation

@cguardia
Copy link
Contributor

@cguardia cguardia commented Sep 24, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #199馃

The following changes to the fixup script are part of the PR:

  • Generate code consistent with the upgrade documentation.
  • Add an option to generate the code using keyword arguments instead of a request.
  • Generate stylistically consistent code (no spaces in keywords, double quotes for strings).
  • Reformat the script itself to use the same code styling.
@cguardia cguardia requested a review from as a code owner Sep 24, 2020
@google-cla google-cla bot added the cla: yes label Sep 24, 2020
@cguardia cguardia requested a review from plamut Sep 24, 2020
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Thank you for this PR.

Loading

@cguardia cguardia merged commit b64e218 into googleapis:master Oct 13, 2020
8 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants