Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix get topic_path in subscriber sample #210

Merged
merged 2 commits into from Sep 28, 2020

Conversation

@ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Sep 25, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #209 馃

Copy link

@marjohkan marjohkan left a comment

Are you meaning to create an instance of pubsub.SubscriberClient and name the variable "publisher"?
Line 40:
# publisher = pubsub.SubscriberClient()

Loading

@ryanyuan ryanyuan force-pushed the fix/subscriber-get-topic-path-docs branch from e2877a5 to 7e45f19 Sep 25, 2020
@ryanyuan
Copy link
Contributor Author

@ryanyuan ryanyuan commented Sep 25, 2020

@marjohkan It should be 'publisher = pubsub.PublisherClient()'. My bad, copy/paste error.

Loading

@ryanyuan ryanyuan removed the request for review from Sep 25, 2020
鈥nto fix/subscriber-get-topic-path-docs
@ryanyuan
Copy link
Contributor Author

@ryanyuan ryanyuan commented Sep 25, 2020

@plamut I just accidentally removed googleapis/api-pubsub from reviewers.

Loading

plamut
plamut approved these changes Sep 28, 2020
Copy link
Contributor

@plamut plamut left a comment

Looks good, thanks for catching and fixing this!

Loading

@plamut
Copy link
Contributor

@plamut plamut commented Sep 28, 2020

"Stream removed" flakiness caused the Python3.7 samples check to fail.

Loading

@plamut plamut merged commit 7228f6c into googleapis:master Sep 28, 2020
8 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants