Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document potentially unexpected blocking behavior of publish() method #214

Merged
merged 4 commits into from Nov 10, 2020

Conversation

@dpcollins-google
Copy link
Contributor

@dpcollins-google dpcollins-google commented Sep 30, 2020

No description provided.

Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

We use conventional commits. Commit messages may not end with a period.

Loading

google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved
Loading
google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved
Loading
@tseaver tseaver changed the title docs: Document potentially unexpected blocking behavior of publish() method docs: document potentially unexpected blocking behavior of publish() method Oct 15, 2020
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Oct 15, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

Loading

1 similar comment
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Oct 15, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

Loading

@anguillanneuf anguillanneuf self-requested a review Oct 15, 2020
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Oct 15, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

Loading

1 similar comment
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Oct 15, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

Loading

@pradn pradn self-requested a review Oct 30, 2020
pradn
pradn approved these changes Oct 30, 2020
@anguillanneuf anguillanneuf merged commit b6d9bd7 into master Nov 10, 2020
7 of 8 checks passed
Loading
@anguillanneuf anguillanneuf deleted the dpcollins-google-patch-1 branch Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants