Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky samples tests #263

Merged
merged 2 commits into from Dec 21, 2020
Merged

fix: flaky samples tests #263

merged 2 commits into from Dec 21, 2020

Conversation

@anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Dec 21, 2020

Fixes #240
Fixes #227
Fixes #246

I can add type hints in samples (#264) and turn on this check in Q1 2021. Setting it to true would cause a lot of lint failures.

Fixes flaky tests that complain about subscription not found.

@google-cla google-cla bot added the cla: yes label Dec 21, 2020
@anguillanneuf anguillanneuf requested a review from pradn Dec 21, 2020
@anguillanneuf anguillanneuf marked this pull request as ready for review Dec 21, 2020
@anguillanneuf anguillanneuf requested a review from as a code owner Dec 21, 2020
@anguillanneuf anguillanneuf requested review from tmatsuo and removed request for Dec 21, 2020
@pradn
Copy link
Contributor

@pradn pradn commented Dec 21, 2020

Thanks! Please add an issue to re-enable the type hints, so we don't forget.

Loading

pradn
pradn approved these changes Dec 21, 2020
@pradn pradn merged commit 3d6a29d into master Dec 21, 2020
8 checks passed
Loading
@anguillanneuf anguillanneuf deleted the flaky_samples_tests branch Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment