Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client version missing from the user agent header #275

Merged
merged 2 commits into from Jan 28, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jan 16, 2021

Fixes #200.

This PR patches the generated code so that client library version is actually included in the x-goog-api-client metrics key.

PR checlist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested a review from a team as a code owner January 16, 2021 09:29
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jan 16, 2021
@@ -97,6 +97,23 @@
\g<0>""",
)

# Make sure that client library version is present in user agent header.
s.replace(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we can update in the Bazel config to avoid manual overrides? https://github.com/googleapis/googleapis/blob/master/google/pubsub/v1/BUILD.bazel

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite familiar with BUILD.bazel, but it looks like pubsub should belong in https://github.com/googleapis/googleapis/tree/master/google/cloud just as pubsublite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto generated code get_distribution method through DistributionNotFound error
3 participants