Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: surface SchemaServiceClient #281

Merged
merged 1 commit into from Jan 29, 2021
Merged

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jan 28, 2021

Closes #280.

This PR surfaces the generated SchemaServiceClient class in the handwritten layer.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@anguillanneuf anguillanneuf changed the title chore: surface SchemaServiceClient feat: surface SchemaServiceClient Jan 28, 2021
@pradn pradn self-requested a review Jan 29, 2021
pradn
pradn approved these changes Jan 29, 2021
Copy link
Contributor

@pradn pradn left a comment

Looks good!

Loading

@anguillanneuf anguillanneuf merged commit 8751bcc into googleapis:master Jan 29, 2021
8 checks passed
Loading
@plamut plamut deleted the iss-280 branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants