Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sample): bump the max_time to 10 mins for a flaky test #311

Merged
merged 1 commit into from Mar 8, 2021

Conversation

@tmatsuo
Copy link
Member

@tmatsuo tmatsuo commented Mar 8, 2021

fixes #291

@tmatsuo tmatsuo requested a review from anguillanneuf Mar 8, 2021
@tmatsuo tmatsuo requested a review from as a code owner Mar 8, 2021
@tmatsuo tmatsuo requested review from leahecole and removed request for Mar 8, 2021
@google-cla google-cla bot added the cla: yes label Mar 8, 2021
@tmatsuo
Copy link
Member Author

@tmatsuo tmatsuo commented Mar 8, 2021

@kamalaboulhosn

We saw a test failure with 404 error with a dlq subscription. In my understanding, Pub/Sub returns 404 when the dlq subscription is not ready yet. I suspect that the dlq subscription was not yet ready after 5 mins from creation. Here I'm bumping the max_time to 10 mins.

I have a question. What's the expected time for a dlq subscription becoming ready? I'd like to set the max_time at around 90 %tile latency with some retries.

Loading

@tmatsuo
Copy link
Member Author

@tmatsuo tmatsuo commented Mar 8, 2021

Let's merge this first and see how it goes.

Loading

@tmatsuo tmatsuo merged commit e2678d4 into googleapis:master Mar 8, 2021
7 checks passed
Loading
@tmatsuo tmatsuo deleted the fix-sample-test branch Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants