Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sample): retry InternalServerError #329

Merged
merged 1 commit into from Mar 15, 2021

Conversation

@tmatsuo
Copy link
Member

@tmatsuo tmatsuo commented Mar 15, 2021

fixes #321

@tmatsuo tmatsuo requested a review from anguillanneuf Mar 15, 2021
@tmatsuo tmatsuo requested a review from as a code owner Mar 15, 2021
@tmatsuo tmatsuo requested review from dinagraves and removed request for Mar 15, 2021
@google-cla google-cla bot added the cla: yes label Mar 15, 2021
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

120s is good, because the sample times out after 90s anyway.

Loading

@anguillanneuf anguillanneuf merged commit 34c9b11 into googleapis:master Mar 15, 2021
7 checks passed
Loading
anguillanneuf added a commit that referenced this issue Mar 30, 2021
…#324)

* Remove EXPERIMENTAL tag for ordering keys in publisher/client.py

* fix(sample): mark test flaky (#326)

* fix(sample): retry InternalServerError (#329)

fixes #321

Co-authored-by: Tianzi Cai <tianzi@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants