Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): implement max_duration_per_lease_extension option #38

Merged
merged 7 commits into from Mar 3, 2020

Conversation

@IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Feb 26, 2020

Closes #35

@IlyaFaer IlyaFaer changed the title Max extension period feat(pubsub): implement max_extension_period Feb 26, 2020
Copy link
Member Author

@IlyaFaer IlyaFaer left a comment

I see few places, where pure percentile is still used:

stream_ack_deadline_seconds = self.ack_histogram.percentile(99)

requests.ModAckRequest(message.ack_id, self._ack_histogram.percentile(99))

My opinion, ack_deadline should be used there, but I'm not very sure

Loading

Loading
Loading
Loading
Loading
@IlyaFaer IlyaFaer requested review from pradn and kamalaboulhosn Feb 26, 2020
@IlyaFaer IlyaFaer marked this pull request as ready for review Feb 26, 2020
google/cloud/pubsub_v1/types.py Outdated Show resolved Hide resolved
Loading
@pradn
Copy link
Contributor

@pradn pradn commented Feb 28, 2020

It looks pretty good, just a small comment.

Let's wait on merging this in until we have word on the final name for "max_extension_period".

Loading

@IlyaFaer IlyaFaer changed the title feat(pubsub): implement max_extension_period feat(pubsub): implement max_duration_per_lease_extension option Mar 2, 2020
google/cloud/pubsub_v1/types.py Outdated Show resolved Hide resolved
Loading
pradn
pradn approved these changes Mar 3, 2020
@pradn pradn merged commit d911a2d into googleapis:master Mar 3, 2020
3 checks passed
Loading
@IlyaFaer IlyaFaer deleted the max_extension_period branch May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants