Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: block until the streaming pull shuts down #424

Merged
merged 1 commit into from Jun 14, 2021

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jun 3, 2021

Fixes #423.

If subscriber client is used as a context manager, we need to block until the shutdown is complete before leaving the with block. See the issue description for more details.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
If subscriber client is used as a context manager, we need to block
until the shutdown is complete before leaving the `with` block.
If not, errors can occur if the underlying gRPC channel is closed before
subscriber client makes the final RPC requests to the server (e.g. auto
NACK anny remaining messages).
@plamut plamut requested a review from anguillanneuf Jun 3, 2021
@plamut plamut requested review from as code owners Jun 3, 2021
@plamut plamut requested review from busunkim96 and removed request for Jun 3, 2021
@google-cla google-cla bot added the cla: yes label Jun 3, 2021
@plamut plamut requested a review from pradn Jun 8, 2021
pradn
pradn approved these changes Jun 11, 2021
Copy link
Contributor

@pradn pradn left a comment

Looks good, thanks!

Loading

@gcf-merge-on-green gcf-merge-on-green bot merged commit d0d0b70 into googleapis:master Jun 14, 2021
10 checks passed
Loading
@plamut plamut deleted the iss-423 branch Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants