Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update generated retry timings for publish and pull rpcs via synth #43

Merged
merged 7 commits into from Mar 23, 2020

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Mar 4, 2020

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/bcdace20-1a27-4371-afe0-2e371d8f7fd8/targets

@busunkim96 busunkim96 requested a review from hongalex Mar 4, 2020
@hongalex hongalex requested a review from pradn Mar 12, 2020
@hongalex hongalex changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. fix: update generated retry timings for publish and pull rpcs (via synth) Mar 12, 2020
@plamut
Copy link
Contributor

@plamut plamut commented Mar 23, 2020

In PR 53 I added a system test that will cover the fix for the DeadlineExceeded errors on synchronous pulls w/o published messages. Please review and merge that, too, once this one gets merged.

Loading

@hongalex hongalex changed the title fix: update generated retry timings for publish and pull rpcs (via synth) fix: update generated retry timings for publish and pull rpcs via synth Mar 23, 2020
pradn
pradn approved these changes Mar 23, 2020
@hongalex hongalex merged commit 4f7fe85 into master Mar 23, 2020
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants