Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dependency on pytz #472

Merged
merged 3 commits into from Aug 13, 2021
Merged

fix: remove dependency on pytz #472

merged 3 commits into from Aug 13, 2021

Conversation

@busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Aug 12, 2021

For googleapis/python-api-core#250

Fixes #468.

@plamut
Copy link
Contributor

@plamut plamut commented Aug 13, 2021

I resolved the merge conflict through the web, I think it should be fine now (no tooling at my disposal, will see what the CI checks say).

Loading

plamut
plamut approved these changes Aug 13, 2021
Copy link
Contributor

@plamut plamut left a comment

Looks good, no traces of pytz anymore, thanks for this!

Loading

@plamut plamut mentioned this pull request Aug 13, 2021
@plamut
Copy link
Contributor

@plamut plamut commented Aug 13, 2021

The Pub/Sub Lite samples check failure is external, i.e. not caused by this PR.

Update: It was a sample for the code that had not been released yet at the time, but now a new version of Pub/Sub Lite has been released. Re-running the checks.

Loading

@gcf-merge-on-green gcf-merge-on-green bot merged commit 972cc16 into master Aug 13, 2021
11 checks passed
Loading
@gcf-merge-on-green gcf-merge-on-green bot deleted the remove-pytz branch Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants