Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify the types of Message parameters #486

Merged
merged 2 commits into from Sep 2, 2021
Merged

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Sep 2, 2021

Closes #485.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
@plamut plamut requested a review from anguillanneuf Sep 2, 2021
@plamut plamut requested review from as code owners Sep 2, 2021
@google-cla google-cla bot added the cla: yes label Sep 2, 2021
@plamut
Copy link
Contributor Author

@plamut plamut commented Sep 2, 2021

@jceresini If you have time, please have a look at this and let me know if the changed docs are now more clear to you, the library user. Thanks!

Loading

@jceresini
Copy link

@jceresini jceresini commented Sep 2, 2021

This definitely helps, and makes sense. Thanks.

Loading

tseaver
tseaver approved these changes Sep 2, 2021
@tseaver tseaver merged commit 633e91b into googleapis:main Sep 2, 2021
10 checks passed
Loading
@plamut plamut deleted the iss-485 branch Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants