Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use client_options.api_endpoint parameter instead of ignoring it #59

Merged
merged 3 commits into from Mar 25, 2020

Conversation

@pradn
Copy link
Contributor

@pradn pradn commented Mar 25, 2020

  • The client_options.api-endpoint parameter was being ignored. This bug prevented users from using regional endpoints. It also made it harder to test code against nonprod endpoints.

Fixes #61

@pradn pradn requested a review from plamut Mar 25, 2020
Copy link
Contributor

@plamut plamut left a comment

Suggested a few Improvements. Let's also open an issue for the fix so that we have it in the next release's changelog.

Loading

google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved
Loading
Copy link
Contributor

@plamut plamut left a comment

The change looks good, let's just cover the problematic edge case with an additional test.

Loading

Loading
plamut
plamut approved these changes Mar 25, 2020
@pradn pradn changed the title fix: use api_endpoint parameter instead of ignoring it fix: use client_options.api_endpoint parameter instead of ignoring it Mar 25, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 56b8d7b into googleapis:master Mar 25, 2020
3 checks passed
Loading
@pradn pradn deleted the fix_api_endpoint branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants