Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict api-core dependency to < 1.17.0 #76

Merged
merged 1 commit into from Apr 16, 2020
Merged

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Apr 16, 2020

Fixes #74
Fixes #75.

The google-api-core version 1.17.0 released yesterday causes problems on re-establishing message streams on retryable errors, thus restricting it.

To test, make a fresh installation of the the pubsub client with and without this version pin change, and try to reproduce the issue as described.

Tip: Deadline Exceeded errors can be triggered by temporarily disable internet connection on the local machine, and then re-enable it to see if the stream is re-established.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
Version 1.17.0 causes problems on re-establishing streams on retryable
errors, thus restricting it.
pradn
pradn approved these changes Apr 16, 2020
@pradn pradn merged commit 191b051 into googleapis:master Apr 16, 2020
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants