Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for v1 #15

merged 2 commits into from Mar 6, 2020

feat: add support for v1 #15

merged 2 commits into from Mar 6, 2020


Copy link

@busunkim96 busunkim96 commented Feb 26, 2020

Primarily adds support for v1 API.

Also includes some template updates.

@googlebot googlebot added the cla: yes label Feb 26, 2020
@busunkim96 busunkim96 self-assigned this Feb 26, 2020
Copy link
Collaborator Author

@busunkim96 busunkim96 commented Feb 27, 2020

index.rst needs a small fix:

Traceback (most recent call last):
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/cmd/", line 276, in build_main, filenames)
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/", line 349, in build
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/builders/", line 299, in build_update
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/builders/", line 311, in build
    updated_docnames = set(
  File "/usr/local/lib/python3.7/", line 119, in __exit__
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/util/", line 219, in pending_warnings
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/util/", line 184, in flushTo
  File "/usr/local/lib/python3.7/logging/", line 1524, in handle
  File "/usr/local/lib/python3.7/logging/", line 1586, in callHandlers
  File "/usr/local/lib/python3.7/logging/", line 890, in handle
    rv = self.filter(record)
  File "/usr/local/lib/python3.7/logging/", line 751, in filter
    result = f.filter(record)
  File "/tmpfs/src/github/python-secret-manager/.nox/docs/lib/python3.7/site-packages/sphinx/util/", line 404, in filter
    raise SphinxWarning(location + ":" + message)
sphinx.errors.SphinxWarning: /tmpfs/src/github/python-secret-manager/docs/index.rst:4:Title underline too short.

v1 Api Reference

Warning, treated as error:
/tmpfs/src/github/python-secret-manager/docs/index.rst:4:Title underline too short.

Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Feb 29, 2020

Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here:

@busunkim96 busunkim96 merged commit cc97391 into master Mar 6, 2020
3 checks passed
3 checks passed
Kokoro Build successful
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.