Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations from path helpers #9

Merged
merged 1 commit into from Jan 6, 2020

Conversation

@sethvargo
Copy link
Contributor

@sethvargo sethvargo commented Dec 27, 2019

As per internal chat @software-dov, these should not be deprecated.

As per internal chat @software-dov, these should not be deprecated.
@software-dov
Copy link

@software-dov software-dov commented Dec 27, 2019

LGTM but cannot approve.

@busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Jan 6, 2020

@software-dov Should we make this change to the generator?

@software-dov
Copy link

@software-dov software-dov commented Jan 6, 2020

It's been made to the generator in googleapis/gapic-generator#3062

@yoshi-kokoro yoshi-kokoro removed the kokoro:run label Jan 6, 2020
@busunkim96 busunkim96 merged commit 723ef9f into googleapis:master Jan 6, 2020
2 checks passed
2 checks passed
Kokoro Build successful
Details
cla/google All necessary CLAs are signed
@sethvargo sethvargo deleted the sethvargo:sethvargo/remove_deprecations branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.