Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Security Command Center UpdateNotificationConfig sample, adding filter to mutable field #39

Merged
merged 1 commit into from Jul 23, 2020

Conversation

hannah-tsai
Copy link
Contributor

Fixes b/155346619
Add "filter" to mutable fields for UpdateNotificationConfig.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 8, 2020
@hannah-tsai hannah-tsai changed the title Update Security Command Center UpdateNotificationConfig doc sample docs: Update Security Command Center UpdateNotificationConfig sample, adding filter to mutable field Jul 8, 2020
@hannah-tsai
Copy link
Contributor Author

Hi,
Not sure why the Kokoro checks didn't seem to finish, any idea on how to restart or resolve this?

@busunkim96
Copy link
Collaborator

@hannah-tsai The CI won't run unless you are a member of an org. Someone with write access needs to nudge it by adding a label.

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2020
@hannah-tsai
Copy link
Contributor Author

Hi, not sure if I should be concerned with the Kokoro build failure?

@busunkim96
Copy link
Collaborator

Hi @hannah-tsai,

Would you mind modifying this PR to change this file instead? I shuffled the snippets into a different directory in #41.

@hannah-tsai hannah-tsai requested a review from a team as a code owner July 22, 2020 20:31
@hannah-tsai hannah-tsai requested review from leahecole and removed request for a team July 22, 2020 20:31
@hannah-tsai
Copy link
Contributor Author

Updated change list, busunkim96@ could you help to add a label to start the Kokoro test? Thanks!

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2020
@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 23, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit c70d790 into googleapis:master Jul 23, 2020
3 of 6 checks passed
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 10, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.7.0](https://www.github.com/googleapis/python-securitycenter/compare/v0.6.0...v0.7.0) (2020-09-10)


### Features

* add field severity to findings; update retry configs ([#53](https://www.github.com/googleapis/python-securitycenter/issues/53)) ([80494a9](https://www.github.com/googleapis/python-securitycenter/commit/80494a915ca33d260862694be889b817869ff01a))


### Documentation

* Update Security Command Center UpdateNotificationConfig sample, adding filter to mutable field ([#39](https://www.github.com/googleapis/python-securitycenter/issues/39)) ([c70d790](https://www.github.com/googleapis/python-securitycenter/commit/c70d7904425ae5ac252ffa7317ec6d08234a6c27))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants