Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: generate with microgenerator #49

Merged
merged 13 commits into from Oct 8, 2020
Merged

feat!: generate with microgenerator #49

merged 13 commits into from Oct 8, 2020

Conversation

busunkim96
Copy link
Collaborator

@busunkim96 busunkim96 commented Jul 28, 2020 •
edited

Blocked googleapis/proto-plus-python#81 is resolved. Stringy enums are now convertible, allowing the library to turn proto in JSON back into library types. 🥳

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2020
@busunkim96 busunkim96 changed the title Microgen2 feat!: generate with microgenerator Jul 28, 2020
arithmetic1728
arithmetic1728 reviewed Jul 28, 2020
View changes
README.rst Show resolved Hide resolved
setup.py Show resolved Hide resolved
@busunkim96 busunkim96 marked this pull request as ready for review July 28, 2020 22:00
@busunkim96 busunkim96 requested a review from a team as a code owner July 28, 2020 22:00
@busunkim96 busunkim96 requested review from leahecole, arithmetic1728 and a team and removed request for a team July 28, 2020 22:00
arithmetic1728
arithmetic1728 approved these changes Jul 28, 2020
View changes
Copy link

@arithmetic1728 arithmetic1728 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the samples are failing, not sure why.

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 28, 2020
@busunkim96 busunkim96 mentioned this pull request Jul 29, 2020
Closed
@product-auto-label product-auto-label bot added the api: securitycenter Issues related to the googleapis/python-securitycenter API. label Aug 21, 2020
@busunkim96 busunkim96 requested a review from a team as a code owner October 1, 2020 22:20
@google-cla
Copy link

google-cla bot commented Oct 1, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 1, 2020
@google-cla
Copy link

google-cla bot commented Oct 1, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@busunkim96
Copy link
Collaborator Author

All commits were made by Googlers with valid CLAs.

@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 1, 2020
@busunkim96
Copy link
Collaborator Author

@leahecole When you have a moment please review the samples https://github.com/googleapis/python-securitycenter/pull/49/files#diff-929314196ba76c84956d324d5c95111e

Thank you!

software-dov
software-dov approved these changes Oct 5, 2020
View changes
Copy link

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leahecole
leahecole reviewed Oct 6, 2020
View changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples LGTM to me if tests are passing with the caveat that I am super unfamiliar with this product

@busunkim96
Copy link
Collaborator Author

@leahecole Thanks for the review! Could you "approve" via the GItHub UI? (it looks like I am blocked from merging b/c of the Codeowners requirement).

Tests are passing: https://source.cloud.google.com/results/invocations/f262a36c-c597-4aed-bf9b-07c5c32aa3f3/targets/github%2Fpython-securitycenter%2Fsamples%2Fsnippets/tests 😁

@leahecole
Copy link
Contributor

Yup sorry about that!

@busunkim96 busunkim96 merged commit 838dbc8 into master Oct 8, 2020
7 checks passed
@release-please release-please bot mentioned this pull request Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@software-dov software-dov software-dov approved these changes

@leahecole leahecole leahecole approved these changes

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Assignees
No one assigned
Labels
api: securitycenter Issues related to the googleapis/python-securitycenter API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@busunkim96 @leahecole @software-dov @arithmetic1728 @yoshi-kokoro