New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add securitycenter prefix to samples, wrap published samples and repl… #85
Merged
gcf-merge-on-green
merged 4 commits into
googleapis:master
from
Strykrol:wrapRegionTags
Dec 15, 2020
Merged
docs: add securitycenter prefix to samples, wrap published samples and repl… #85
gcf-merge-on-green
merged 4 commits into
googleapis:master
from
Strykrol:wrapRegionTags
Dec 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace unpublished entirely.
Here is the summary of possible violations There are 41 possible violations for not having product prefix.
Here is the summary of changes. You added 41 region tags.
You deleted 6 region tags.
This comment is generated by snippet-bot.
|
busunkim96
approved these changes
Dec 14, 2020
lgtm once lint failures are resolved |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 15, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/python-securitycenter/compare/v1.0.0...v1.1.0) (2020-12-15) ### Features * **v1:** add field severity to findings; add common resource helper; expose client tranport ([#87](https://www.github.com/googleapis/python-securitycenter/issues/87)) ([e28b8e2](https://www.github.com/googleapis/python-securitycenter/commit/e28b8e24ac8a01a3db95decf21a635b046ecce97)), closes [/github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py#L27-L32](https://www.github.com/googleapis//github.com/googleapis/python-talent/blob/ef045e8eb348db36d7a2a611e6f26b11530d273b/samples/snippets/noxfile_config.py/issues/L27-L32) ### Documentation * add securitycenter prefix to samples, wrap published samples and repl… ([#85](https://www.github.com/googleapis/python-securitycenter/issues/85)) ([553dfbb](https://www.github.com/googleapis/python-securitycenter/commit/553dfbb89f7e72ad280aaa5d59cc4a054aa1948e)) * update documentation on severity ([#72](https://www.github.com/googleapis/python-securitycenter/issues/72)) ([4ba96b2](https://www.github.com/googleapis/python-securitycenter/commit/4ba96b268d92eb57b816593b1fb968f269ed188e)) * update snippets_findings tags ([#78](https://www.github.com/googleapis/python-securitycenter/issues/78)) ([c7e301f](https://www.github.com/googleapis/python-securitycenter/commit/c7e301f0d45d2e3d04263df63a515b52ce0391b3)) * update snippets_list_assets tags ([#77](https://www.github.com/googleapis/python-securitycenter/issues/77)) ([11aef56](https://www.github.com/googleapis/python-securitycenter/commit/11aef56a0a9cf281e0d647d64d72c921e4b837d0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 18, 2021
Updates the tags to be identical to the tag most-used in other language-repos. This is the final step in wrangling all the cats into logical groupings of identical tags. Cleans up and finalizes work started in PR #85.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: securitycenter
Issues related to the googleapis/python-securitycenter API.
cla: yes
This human has signed the Contributor License Agreement.
samples
Issues that are directly related to samples.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Standardizing Security Command Center samples to use 'securitycenter' prefixing. Wrapped existing samples to keep published doclinks unbroken, and fully replaced the ones that aren't published. Once this PR is through, published sample inclusions will be updated to use the new prefix, then I'll come through again and remove the unused block wraps.