Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resume iterator on EOS internal error #122

Merged
merged 5 commits into from Aug 25, 2020
Merged

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Aug 4, 2020

Fixes #120

This fixes the same issue as googleapis/java-spanner#360.

A similar issue was encountered by bigquery-storage and was fixed in googleapis/google-cloud-python#9994.

@larkee larkee requested review from thiagotnunes and crwilcox Aug 4, 2020
@larkee larkee requested a review from as a code owner Aug 4, 2020
@larkee larkee self-assigned this Aug 4, 2020
@google-cla google-cla bot added the cla: yes label Aug 4, 2020
Copy link

@hengfengli hengfengli left a comment

I think we need to add retry for "Received unexpected EOS on DATA frame from server" error message as well.

@larkee larkee requested a review from hengfengli Aug 7, 2020
@thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Aug 10, 2020

@larkee thanks for the fix, I will test it out with a long running PDML to make sure everything we need is in place!

tseaver
tseaver previously requested changes Aug 14, 2020
Copy link
Contributor

@tseaver tseaver left a comment

This change really needs unit test coverage: I'm not sure why the Kokoro build is passing without it.

google/cloud/spanner_v1/snapshot.py Outdated Show resolved Hide resolved
@thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Aug 20, 2020

@larkee Quick update, the PDML long running task finished successfully in production testing. Thanks for fixing this!

@product-auto-label product-auto-label bot added the api: spanner label Aug 21, 2020
larkee and others added 2 commits Aug 24, 2020
@google-cla
Copy link

@google-cla google-cla bot commented Aug 24, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 24, 2020
@larkee larkee requested a review from tseaver Aug 24, 2020
@larkee larkee added cla: yes and removed cla: no labels Aug 24, 2020
@larkee larkee dismissed tseaver’s stale review Aug 25, 2020

The unit test coverage is back to 100% for all files touched by this change.

@larkee larkee requested a review from hengfengli Aug 25, 2020
Copy link

@hengfengli hengfengli left a comment

LGTM. 👍

@larkee larkee merged commit 45a1538 into googleapis:master Aug 25, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants