Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add install reference for cloud trace exporter (opentelemetry) #127

Merged

Conversation

cnnradams
Copy link
Contributor

@cnnradams cnnradams commented Aug 5, 2020

The example uses the Cloud Trace exporter, but there is no pip install mentioned for it in the example.

+ misc doc fixes

@cnnradams cnnradams requested a review from as a code owner Aug 5, 2020
@google-cla google-cla bot added the cla: yes label Aug 5, 2020
@hengfengli hengfengli added the kokoro:run label Aug 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run label Aug 5, 2020
@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 5, 2020

Likely needs to have PR #124 merged before the main Kokoro build will pass.

Copy link

@hengfengli hengfengli left a comment

LGTM.

@hengfengli hengfengli added the kokoro:run label Aug 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run label Aug 6, 2020
@hengfengli
Copy link

@hengfengli hengfengli commented Aug 6, 2020

@larkee Could you please help to rebase this PR? I can't do it because the associated email is not my google address.

Do you have any idea why Kokoro docs-presubmit fails? I tried to check the invocation log, but it is empty.

I think the failed test is not caused by this change. It happens in another PR as well: #129.

@hengfengli hengfengli added the kokoro:run label Aug 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run label Aug 6, 2020
@larkee
Copy link
Contributor

@larkee larkee commented Aug 7, 2020

@larkee Could you please help to rebase this PR? I can't do it because the associated email is not my google address.

Do you have any idea why Kokoro docs-presubmit fails? I tried to check the invocation log, but it is empty.

I think the failed test is not caused by this change. It happens in another PR as well: #129.

The docs-presubmit is a new CI test that is relying on files that don't yet exist. I'm working on fixing this in #126. I'll prioritize that to unblock this change 👍

docs/opentelemetry-tracing.rst Outdated Show resolved Hide resolved
cnnradams and others added 2 commits Aug 7, 2020
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
@hengfengli hengfengli added the kokoro:run label Aug 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run label Aug 7, 2020
larkee
larkee approved these changes Aug 7, 2020
@larkee larkee added automerge kokoro:force-run labels Aug 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Aug 7, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 23fcd4c into googleapis:master Aug 7, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants