Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add client_options to base class #132

Merged
merged 3 commits into from Aug 14, 2020

Conversation

HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Aug 10, 2020

Fixes #116 馃

@HemangChothani HemangChothani requested review from tseaver and larkee Aug 10, 2020
@HemangChothani HemangChothani requested a review from as a code owner Aug 10, 2020
@google-cla google-cla bot added the cla: yes label Aug 10, 2020
larkee
larkee approved these changes Aug 11, 2020
Copy link
Contributor

@larkee larkee left a comment

LGTM, just some minor things

tests/unit/test_client.py Outdated Show resolved Hide resolved
tests/unit/test_client.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@tseaver tseaver merged commit 6851bb8 into googleapis:master Aug 14, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants