Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): exporting transaction._rolled_back as transaction.rolled_back #16

Merged
merged 2 commits into from Feb 18, 2020

Conversation

HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Feb 12, 2020

Fixes #13

@HemangChothani HemangChothani requested a review from larkee Feb 12, 2020
@googlebot googlebot added the cla: yes label Feb 12, 2020
@HemangChothani
Copy link
Contributor Author

@HemangChothani HemangChothani commented Feb 12, 2020

Just another alternative, the changes could be confined to the Transaction class:

@property
def rolled_back(self):
    return self._rolled_back

@rolled_back.setter
def rolled_back(self, value):
    self._rolled_back = value

Copy link
Contributor

@crwilcox crwilcox left a comment

This change looks good to me. Will leave it to @larkee to approve.

larkee
larkee approved these changes Feb 18, 2020
Copy link
Contributor

@larkee larkee left a comment

LGTM. Thanks for doing this! :)

@larkee larkee merged commit 974ee92 into googleapis:master Feb 18, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants