Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbapi): add aborted transactions retry support #168

Merged
merged 5 commits into from Nov 23, 2020

Conversation

IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Nov 12, 2020

@IlyaFaer IlyaFaer added api: spanner type: feature request labels Nov 12, 2020
@google-cla google-cla bot added the cla: yes label Nov 12, 2020
@IlyaFaer IlyaFaer marked this pull request as ready for review Nov 13, 2020
@IlyaFaer IlyaFaer requested a review from as a code owner Nov 13, 2020
@IlyaFaer IlyaFaer requested a review from c24t Nov 13, 2020
Copy link
Contributor

@c24t c24t left a comment

LGTM with a few minor comments. I checked that this matches the diffs from googleapis/python-spanner-django#544 and googleapis/python-spanner-django#543, see the comments there for more info.

google/cloud/spanner_dbapi/checksum.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/connection.py Show resolved Hide resolved
tests/system/test_system.py Outdated Show resolved Hide resolved
@@ -0,0 +1,63 @@
# Copyright 2020 Google LLC
Copy link
Contributor

@c24t c24t Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another packaging thing to consider: we might want to move all the DBAPI tests under google/cloud/spanner_dbapi/tests/ so the code and tests live in the same package.

larkee
larkee approved these changes Nov 23, 2020
Copy link
Contributor

@larkee larkee left a comment

LGTM 👍

@c24t c24t merged commit d59d502 into googleapis:master Nov 23, 2020
9 checks passed
@IlyaFaer IlyaFaer deleted the transaction_retry branch Nov 25, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants