Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove adding a dummy WHERE clause into UPDATE and DELETE statements #169

Merged
merged 2 commits into from
Nov 20, 2020

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Nov 16, 2020

Continuation of the PR in django-spanner, only DB API part.

@IlyaFaer IlyaFaer added api: spanner Issues related to the googleapis/python-spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 16, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2020
@IlyaFaer IlyaFaer marked this pull request as ready for review November 16, 2020 09:14
@IlyaFaer IlyaFaer requested a review from a team as a code owner November 16, 2020 09:14
@IlyaFaer IlyaFaer requested a review from c24t November 16, 2020 09:14
@c24t c24t changed the title feat: don't add dummy WHERE clause into UPDATE and DELETE queries feat: Add dummy WHERE clause to certain statements Nov 19, 2020
Copy link
Contributor

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, heads up that I changed the title to match googleapis/python-spanner-django#516.

Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title doesn't seem to match what the feature is. The feature removes adding dummy WHERE clauses.

google/cloud/spanner_dbapi/parse_utils.py Outdated Show resolved Hide resolved
@IlyaFaer IlyaFaer changed the title feat: Add dummy WHERE clause to certain statements feat: remove adding a dummy WHERE clause into UPDATE and DELETE statements Nov 19, 2020
@larkee larkee merged commit 7f4d478 into googleapis:master Nov 20, 2020
@IlyaFaer IlyaFaer deleted the dummy_where_clause branch November 20, 2020 08:13
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants