Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove erroneous timeouts for batch_create_session calls #18

Merged
merged 4 commits into from Feb 19, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Feb 18, 2020

Currently the timeout that is used for getting a session from the pool is mistakenly being used for the batch_create_sessions calls that are used to initially fill pools. If the timeout is short, the call does not have time to complete and the pools fails to initialize. Removing this timeout means the default timeout for BatchCreateSessions will be used.

@larkee larkee added the api: spanner label Feb 18, 2020
@larkee larkee requested a review from skuruppu Feb 18, 2020
@googlebot googlebot added the cla: yes label Feb 18, 2020
@larkee larkee merged commit 997a034 into googleapis:master Feb 19, 2020
3 checks passed
@larkee larkee deleted the remove-erroneous-timeouts branch Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants