Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename to fix "Mismatched region tag" check #201

merged 2 commits into from Dec 29, 2020


Copy link

@c24t c24t commented Dec 22, 2020

Quick fix for failing "Mismatched region tag" checks like this one.

I didn't change the names of any class-level constants, just the ones defined in individual tests. Even though we only need to rename "START" and "END" to fix the check, I thought it would be better to make them all consistent.

@c24t c24t requested a review from as a code owner Dec 22, 2020
@product-auto-label product-auto-label bot added the api: spanner label Dec 22, 2020
@google-cla google-cla bot added the cla: yes label Dec 22, 2020
Copy link

@snippet-bot snippet-bot bot commented Dec 22, 2020

Here is the summary of changes.

You deleted 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

larkee approved these changes Dec 22, 2020
Copy link

@larkee larkee left a comment

LGTM 👍 Good call on the consistency!

@c24t c24t added the kokoro:force-run label Dec 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Dec 22, 2020
c24t added a commit that referenced this issue Dec 22, 2020
Fixes #198, includes #201.

Fix a bug in around backup instance proto conversion.
@larkee larkee merged commit c000ec4 into googleapis:master Dec 29, 2020
9 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 15, 2021
🤖 I have created a release \*beep\* \*boop\* 
## [3.0.0]( (2021-01-15)


* convert operations pbs into Operation objects when listing operations (#186)

### Features

* add support for instance labels ([#193]( ([ed462b5](
* add support for ssl credentials; add throttled field to UpdateDatabaseDdlMetadata ([#161]( ([2faf01b](
* adding missing docstrings for functions & classes  ([#188]( ([9788cf8](
* autocommit sample ([#172]( ([4ef793c](

### Bug Fixes

* convert operations pbs into Operation objects when listing operations ([#186]( ([ed7152a](
* Convert PBs in system test cleanup ([#199]( ([ede4343](
* **dbapi:** autocommit enabling fails if no transactions begun ([#177]( ([e981adb](
* **dbapi:** executemany() hiding all the results except the last ([#181]( ([020dc17](
* **dbapi:** Spanner protobuf changes causes KeyError's ([#206]( ([f1e21ed](
* remove client side gRPC receive limits ([#192]( ([90effc4](
* Rename to fix "Mismatched region tag" check ([#201]( ([c000ec4](

### Documentation

* homogenize region tags ([#194]( ([1501022](
* homogenize region tags pt 2 ([#202]( ([87789c9](
* update CHANGELOG breaking change comment ([#180]( ([c7b3b9e](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: spanner cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants