Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db_api): add dummy lastrowid attribute #227

Merged
merged 1 commit into from Feb 15, 2021
Merged

Conversation

IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Feb 8, 2021

According to PEP 249, lastrowid should be set to None if it's impossible to set it correctly.

@google-cla google-cla bot added the cla: yes label Feb 8, 2021
@product-auto-label product-auto-label bot added the api: spanner label Feb 8, 2021
@IlyaFaer IlyaFaer added the type: bug label Feb 8, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review Feb 8, 2021
@IlyaFaer IlyaFaer requested a review from as a code owner Feb 8, 2021
larkee
larkee approved these changes Feb 8, 2021
@larkee larkee merged commit 0375914 into googleapis:master Feb 15, 2021
9 checks passed
@IlyaFaer IlyaFaer deleted the lastrowid branch Feb 15, 2021
@IlyaFaer IlyaFaer restored the lastrowid branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants