Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db_api): use correct connection attribute when handling Aborted errors #228

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

HemangChothani
Copy link
Contributor

Fixes #225

This PR include error related unit tests to raise the coverage of "DB_API".

@HemangChothani HemangChothani requested a review from a team as a code owner February 8, 2021 10:57
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2021
@larkee
Copy link
Contributor

larkee commented Feb 9, 2021

Thank you for making this PR! Improved test coverage is always appreciated. Are there plans to improve the coverage for google/cloud/spanner_dbapi/utils.py and google/cloud/spanner_dbapi/connection.py as well?

@HemangChothani
Copy link
Contributor Author

Yes, I will open other PR soon.

Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@larkee larkee changed the title fix(db_api): connection attribute of connection class and include related unit tests fix(db_api): use correct connection attribute when handling Aborted errors Feb 15, 2021
@larkee larkee merged commit 4afea77 into googleapis:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

db_api: cursor class doesn't have _connection attribute
2 participants