Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db_api): update parse_util output for homogeneous statements #233

Merged
merged 1 commit into from Feb 18, 2021

Conversation

HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Feb 11, 2021

Fixes #232

@HemangChothani HemangChothani requested review from larkee and c24t Feb 11, 2021
@HemangChothani HemangChothani requested a review from as a code owner Feb 11, 2021
@google-cla google-cla bot added the cla: yes label Feb 11, 2021
@product-auto-label product-auto-label bot added the api: spanner label Feb 11, 2021
"table": match.group("table_name"),
"columns": columns,
"values": rows_list,
}
Copy link
Contributor

@larkee larkee Feb 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change?

Copy link
Contributor Author

@HemangChothani HemangChothani Feb 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope i think.

Copy link
Contributor

@larkee larkee Feb 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. The docstring correctly documents this behavior. In that case, I don't think this is a breaking change since it is fixing it to match the documented behavior.

@larkee
Copy link
Contributor

@larkee larkee commented Feb 15, 2021

Please update the title to be more descriptive i.e. fix: update parse_util output for homogeneous statements

The PR title will be used in the release notes.

@HemangChothani HemangChothani changed the title fix: fix execute insert for homogeneous statement fix: update parse_util output for homogeneous statements Feb 15, 2021
Copy link
Contributor

@larkee larkee left a comment

LGTM once the title is updated

"table": match.group("table_name"),
"columns": columns,
"values": rows_list,
}
Copy link
Contributor

@larkee larkee Feb 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. The docstring correctly documents this behavior. In that case, I don't think this is a breaking change since it is fixing it to match the documented behavior.

@HemangChothani
Copy link
Contributor Author

@HemangChothani HemangChothani commented Feb 15, 2021

LGTM once the title is updated

I have changed the title.

larkee
larkee approved these changes Feb 16, 2021
@larkee larkee changed the title fix: update parse_util output for homogeneous statements fix(db_api): update parse_util output for homogeneous statements Feb 16, 2021
@larkee larkee merged commit 36b12a7 into googleapis:master Feb 18, 2021
9 checks passed
IlyaFaer pushed a commit to q-logic/python-spanner that referenced this issue Mar 22, 2021
larkee pushed a commit that referenced this issue Mar 24, 2021
* fix: revert #233

* update docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants