Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db_api): revert Mutations API usage #285

merged 2 commits into from Mar 24, 2021


Copy link

@IlyaFaer IlyaFaer commented Mar 22, 2021

This PR reverts changes made in #233.

I've executed SQLAlchemy tests several times - looks like with #233 changes reverted everything is working fine now. I've mentioned that DLL test_create is failing when 223 is reverted, but it's no more actual, so we can safely revert it I assume - I only have those 3 tests mentioned in the comment failing, which is expected for now.

@IlyaFaer IlyaFaer added the api: spanner label Mar 22, 2021
@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@IlyaFaer IlyaFaer requested a review from larkee Mar 22, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review Mar 22, 2021
@IlyaFaer IlyaFaer requested a review from as a code owner Mar 22, 2021
Copy link

@larkee larkee commented Mar 22, 2021

Could you run the Django system tests with and without this change to make sure that any there aren't any unexpected breakages?

Copy link
Member Author

@IlyaFaer IlyaFaer commented Mar 22, 2021

@larkee, I've used the PR to execute all the checks. Penultimate run wasn't using any special branches, while the last one does. Both have the same several failures, which seems to be unrelated.

Copy link

@larkee larkee commented Mar 22, 2021

Confirmed the failures are the same and unrelated.

LGTM, could you update the docstring to match the changed behaviour? The original change was made to match the docstring.

@larkee larkee added the kokoro:force-run label Mar 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 24, 2021
larkee approved these changes Mar 24, 2021
@larkee larkee changed the title fix(db_api): revert #233 changes fix(db_api): revert Mutations API usage Mar 24, 2021
@larkee larkee merged commit e5d4901 into googleapis:master Mar 24, 2021
8 checks passed
@IlyaFaer IlyaFaer deleted the revert_233 branch Mar 24, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 25, 2021
🤖 I have created a release \*beep\* \*boop\*
## [3.3.0]( (2021-03-25)

### Features

* add encryption_info to Database ([#284]( ([2fd0352](
* add support for CMEK ([#105]( ([e990ff7](
* add support for custom timeout and retry parameters in execute_update method in transactions ([#251]( ([8abaebd](
* added retry and timeout params to partition read in database and snapshot class ([#278]( ([1a7c9d2](
* **db_api:** support executing several DDLs separated by semicolon ([#277]( ([801ddc8](

### Bug Fixes

* avoid consuming pending null values when merging ([#286]( ([c6cba9f](
* **db_api:** allow file path for credentials ([#221]( ([1de0284](
* **db_api:** ensure DDL statements are being executed ([#290]( ([baa02ee](
* **db_api:** revert Mutations API usage ([#285]( ([e5d4901](

### Documentation

* fix docstring types and typos ([#259]( ([1b0ce1d](
* fix snapshot usage ([#291]( ([eee2181](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: spanner cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants