Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbapi): remove string conversion for numeric fields #317

Merged
merged 9 commits into from
Apr 26, 2021
Merged

feat(dbapi): remove string conversion for numeric fields #317

merged 9 commits into from
Apr 26, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Apr 23, 2021

feat: added support for converting decimal field to numeric field and removed it's conversion to string

Fixes #315 馃

Merging from original repo to update fork.
docs: fix docstring types and typos (#259)
updating repo from source.
updating with source master.
update master branch from source branch.
@vi3k6i5 vi3k6i5 requested a review from a team as a code owner April 23, 2021 16:51
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Apr 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2021
@vi3k6i5 vi3k6i5 requested review from skuruppu and larkee April 23, 2021 16:55
@vi3k6i5
Copy link
Contributor Author

vi3k6i5 commented Apr 24, 2021

github actions are not running, pausing this PL and will retry.

@vi3k6i5 vi3k6i5 closed this Apr 24, 2021
@vi3k6i5 vi3k6i5 reopened this Apr 24, 2021
@vi3k6i5 vi3k6i5 closed this Apr 24, 2021
@vi3k6i5 vi3k6i5 reopened this Apr 24, 2021
@larkee larkee changed the title feat: added support for converting decimal field to numeric field and removed it's conversion to string feat(dbapi): remove string conversion for numeric fields Apr 26, 2021
@larkee larkee merged commit 772aa3c into googleapis:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

float value cannot be used to insert data to NUMERIC field.
2 participants