Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to support the open-telemetry status code spec change #358

Merged
merged 14 commits into from Jun 11, 2021
Merged

fix: update to support the open-telemetry status code spec change #358

merged 14 commits into from Jun 11, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Jun 2, 2021

fix: for open-telemetry status code spec change

Fixes #357 馃

Open telemetry has changed their specs for status code. Since the open telemetry library for python is still in beta it doesn't make much sense to use/support older version of that library.

Couple of reference:

  1. 'StatusCanonicalCode' is not part of 'opentelemetry.trace.status'
  2. In memory exporter not resetting after test case ends

@vi3k6i5 vi3k6i5 requested a review from as a code owner Jun 2, 2021
@google-cla google-cla bot added the cla: yes label Jun 2, 2021
@product-auto-label product-auto-label bot added the api: spanner label Jun 2, 2021
Copy link
Contributor

@larkee larkee left a comment

Is this compatible with older versions of OpenTelemetry?

Also, the py3.6 unit tests are failing.

@vi3k6i5
Copy link
Contributor Author

@vi3k6i5 vi3k6i5 commented Jun 4, 2021

Is this compatible with older versions of OpenTelemetry?

Don't think we should support any older versions of the library. As per the library doc the software is in Beta, and since they have changed their api, so not sure if we should support older versions?

Also, the py3.6 unit tests are failing.

Fixed the unit tests and system tests.

Copy link
Contributor

@larkee larkee left a comment

The emulator action is timing out while trying to resolve the dependencies. It seems to have an issue with opentelemetry-instrumentation == 0.22b0 in the constraints file. Using opentelemetry-instrumentation == 0.20b0 seems to resolve it but I don't know if this is a valid version..

@vi3k6i5 vi3k6i5 added the kokoro:force-run label Jun 8, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 8, 2021
@vi3k6i5
Copy link
Contributor Author

@vi3k6i5 vi3k6i5 commented Jun 9, 2021

The emulator action is timing out while trying to resolve the dependencies. It seems to have an issue with opentelemetry-instrumentation == 0.22b0 in the constraints file. Using opentelemetry-instrumentation == 0.20b0 seems to resolve it but I don't know if this is a valid version..

Thanks for the help, that fixed the issue. Thanks 馃憤

larkee
larkee approved these changes Jun 11, 2021
@larkee larkee changed the title fix: for open-telemetry status code spec change fix: update to support the open-telemetry status code spec change Jun 11, 2021
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Jun 11, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@larkee larkee merged commit 0f894f1 into googleapis:master Jun 11, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants