Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable always_use_jwt_access #395

Merged

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jun 29, 2021

fix: disable always_use_jwt_access

Committer: @busunkim96
PiperOrigin-RevId: 382142900

Source-Link: googleapis/googleapis@513440f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/7b1e2c31233f79a704ec21ca410bf661d6bc68d0

@gcf-owl-bot gcf-owl-bot bot requested a review from as a code owner Jun 29, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Jun 29, 2021
@product-auto-label product-auto-label bot added the api: spanner label Jun 29, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Jun 29, 2021
@google-cla google-cla bot added the cla: yes label Jun 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 29, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Jun 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 29, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Jun 29, 2021
@parthea parthea changed the title chore: use gapic-generator-python 0.50.3 fix: disable always_use_jwt_access Jun 30, 2021
@parthea parthea added the kokoro:run label Jun 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run label Jun 30, 2021
@parthea parthea added the kokoro:force-run label Jun 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 30, 2021
@skuruppu skuruppu added the kokoro:force-run label Jul 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 2, 2021
@skuruppu skuruppu added automerge and removed automerge labels Jul 2, 2021
@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Jul 3, 2021

@parthea we were finally able to get the tests passing yesterday and merged in #381. But now most of the owl-bot PRs have this set of conflicts relating to always_use_jwt_access. Would you be able to help us resolve them?

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Jul 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 3, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Jul 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 3, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run label Jul 3, 2021
@google-cla
Copy link

@google-cla google-cla bot commented Jul 3, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jul 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 3, 2021
@parthea
Copy link
Contributor

@parthea parthea commented Jul 3, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 3, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Jul 3, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Jul 3, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Jul 3, 2021
@parthea parthea added the owlbot:run label Jul 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 3, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Jul 3, 2021
@parthea
Copy link
Contributor

@parthea parthea commented Jul 3, 2021

@skuruppu Done

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run owlbot:run labels Jul 3, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 3, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Jul 3, 2021
@parthea parthea added the automerge label Jul 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c37bf21 into master Jul 5, 2021
11 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-5fb7cf18-6c7d-4b9a-856c-3558962f0930 branch Jul 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Jul 5, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 30, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [3.7.0](https://www.github.com/googleapis/python-spanner/compare/v3.6.0...v3.7.0) (2021-07-29)


### Features

* add always_use_jwt_access ([#381](https://www.github.com/googleapis/python-spanner/issues/381)) ([0f1a5de](https://www.github.com/googleapis/python-spanner/commit/0f1a5ded572685a96d29a60c959cb00a48f7a87f))
* add configurable leader placement support ([#399](https://www.github.com/googleapis/python-spanner/issues/399)) ([7f1b120](https://www.github.com/googleapis/python-spanner/commit/7f1b1209e62062014545cf959d41f04184552eec))
* add sample for low cost instances ([#392](https://www.github.com/googleapis/python-spanner/issues/392)) ([3f4f93f](https://www.github.com/googleapis/python-spanner/commit/3f4f93f75f5585a82047bf8d83a24622ad776ecb))


### Bug Fixes

* avoid bad version of `opentelemetry-instrumentation` ([#429](https://www.github.com/googleapis/python-spanner/issues/429)) ([1620c12](https://www.github.com/googleapis/python-spanner/commit/1620c12a56e0d007cf010690bab303db06d0c914))
* **deps:** pin 'google-{api,cloud}-core' to allow 2.x versions ([#415](https://www.github.com/googleapis/python-spanner/issues/415)) ([b0455d0](https://www.github.com/googleapis/python-spanner/commit/b0455d0ab657cd053a7527e99bdbfadc4de23b30))
* disable always_use_jwt_access ([c37bf21](https://www.github.com/googleapis/python-spanner/commit/c37bf21afdf417757eff67fe8500aa65f49fd5ad))
* disable always_use_jwt_access ([#395](https://www.github.com/googleapis/python-spanner/issues/395)) ([c37bf21](https://www.github.com/googleapis/python-spanner/commit/c37bf21afdf417757eff67fe8500aa65f49fd5ad))
* enable self signed jwt for grpc ([#427](https://www.github.com/googleapis/python-spanner/issues/427)) ([2487800](https://www.github.com/googleapis/python-spanner/commit/2487800e31842a44dcc37937c325e130c8c926b0))
* support merging for NUMERIC values ([#434](https://www.github.com/googleapis/python-spanner/issues/434)) ([06b4215](https://www.github.com/googleapis/python-spanner/commit/06b4215f76ae806eba1d0d07115c8c90b8c7482d)), closes [#433](https://www.github.com/googleapis/python-spanner/issues/433)


### Documentation

* fix docstring for session.py ([#387](https://www.github.com/googleapis/python-spanner/issues/387)) ([3132587](https://www.github.com/googleapis/python-spanner/commit/3132587453f7bd0be72ebc393626b5c8b1bab982))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants