Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use DML batches in executemany() method #412

Merged
merged 25 commits into from Aug 9, 2021

Conversation

IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Jul 14, 2021

No description provided.

@IlyaFaer IlyaFaer added api: spanner type: feature request labels Jul 14, 2021
@google-cla google-cla bot added the cla: yes label Jul 14, 2021
google/cloud/spanner_dbapi/cursor.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/cursor.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/connection.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/cursor.py Outdated Show resolved Hide resolved
@IlyaFaer IlyaFaer requested a review from larkee Jul 19, 2021
google/cloud/spanner_dbapi/cursor.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/cursor.py Show resolved Hide resolved
google/cloud/spanner_dbapi/cursor.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/cursor.py Show resolved Hide resolved
google/cloud/spanner_dbapi/cursor.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/cursor.py Outdated Show resolved Hide resolved
tests/unit/spanner_dbapi/test_connection.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/cursor.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/connection.py Outdated Show resolved Hide resolved
@IlyaFaer IlyaFaer marked this pull request as ready for review Jul 29, 2021
@IlyaFaer IlyaFaer requested a review from as a code owner Jul 29, 2021
@IlyaFaer IlyaFaer added the kokoro:force-run label Jul 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 30, 2021
@IlyaFaer IlyaFaer changed the title feat: use mutations for executemany() inserts feat: use DML batches in executemany() method Jul 30, 2021
google/cloud/spanner_dbapi/connection.py Show resolved Hide resolved
google/cloud/spanner_dbapi/connection.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/cursor.py Show resolved Hide resolved
Copy link
Contributor

@larkee larkee left a comment

LGTM, but would you mind updating the DML in the test_execute_many system test so that we are testing this feature against the emulator and production?

larkee
larkee approved these changes Aug 9, 2021
@larkee larkee merged commit cbb4ee3 into googleapis:master Aug 9, 2021
10 checks passed
@IlyaFaer IlyaFaer deleted the mutations_support branch Aug 9, 2021
larkee pushed a commit that referenced this issue Aug 11, 2021
* tests: move instance API systests to own module

Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup / teardown.

Toward #472.

* tests: move database API systests to own module

Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup / teardown.

Toward #472.

* tests: move table API systests to own module

Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup / teardown.

Toward #472.

* tests: move backup API systests to own module [WIP]

Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup / teardown.

Toward #472.

* tests: move streaming/chunnking systests to own module

Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup / teardown.

Toward #472.

* tests: move session API systests to own module

Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup/ teardown.

Toward #472.

* tests: move dbapi systests to owwn module

Refactor to use pytest fixtures / idioms, rather than old 'Confog'
setup / teardown.

Toward #472.

* tests: remove legacy systest setup / teardown code

Closes #472.

* tests: don't pre-create datbase before restore attempt

* tests: fix instance config fixtures under emulator

* tests: clean up alt instnce at module scope

Avoids clash with 'test_list_instances' expectatons.

* tests: work around MethodNotImplemented

Raised from 'ListBackups' API on the CI emulator, but not locally.

* chore: drop use of pytz in systests

See #479 for rationale.

* chore: fix fossil in comment

* chore: move '_check_batch_status' to only calling module

Likewise the 'FauxCall' helper class it uses.

* chore: improve testcase name

* tests: replicate dbapi systest changes from #412 into new module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants