Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(samples): batch_update() results processing error #484

Merged
merged 4 commits into from Aug 15, 2021

Conversation

IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Aug 11, 2021

The original batch_update() method returns two values: batch status and row counts, while the sample accepts only one value from the method call (and checks its length, which is always equal to 2).

@IlyaFaer IlyaFaer added type: bug samples labels Aug 11, 2021
@google-cla google-cla bot added the cla: yes label Aug 11, 2021
@product-auto-label product-auto-label bot added the api: spanner label Aug 11, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review Aug 11, 2021
@IlyaFaer IlyaFaer requested review from as code owners Aug 11, 2021
@IlyaFaer IlyaFaer requested review from dandhlee and larkee Aug 11, 2021
samples/samples/snippets.py Outdated Show resolved Hide resolved
larkee
larkee approved these changes Aug 13, 2021
@larkee larkee merged commit bdd5f8b into googleapis:master Aug 15, 2021
10 checks passed
@IlyaFaer IlyaFaer deleted the sample_fix branch Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes samples type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants