Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add keepalive to gRPC channel #49

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Apr 8, 2020

This patch adds keepalives to the GRPC channel every 2 minutes. By default, there are no keepalives to the GRPC channel. There have been issues observed with seeing DEADLINE_EXCEEDED errors at 10 minutes despite the timeout being longer eg 1 hour. Adding keepalives will hopefully address this. This fix has been added to the Java client for similar reasons.

@larkee larkee requested a review from skuruppu April 8, 2020 00:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2020
Copy link

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 8, 2020
@larkee larkee merged commit dfbc656 into googleapis:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants