Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db_api): move connection validation into a separate method #543

Merged
merged 6 commits into from Sep 7, 2021

Conversation

IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Aug 27, 2021

@IlyaFaer IlyaFaer added the api: spanner label Aug 27, 2021
@google-cla google-cla bot added the cla: yes label Aug 27, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review Aug 27, 2021
@IlyaFaer IlyaFaer requested a review from as a code owner Aug 27, 2021
@IlyaFaer IlyaFaer requested a review from larkee Aug 27, 2021
Copy link
Contributor

@larkee larkee left a comment

This PR will not behave as intended against production. Please add system tests.

tests/unit/spanner_dbapi/test_connection.py Show resolved Hide resolved
google/cloud/spanner_dbapi/connection.py Outdated Show resolved Hide resolved
google/cloud/spanner_dbapi/connection.py Outdated Show resolved Hide resolved
larkee
larkee approved these changes Sep 2, 2021
Copy link
Contributor

@larkee larkee left a comment

LGTM with the docstring addition

google/cloud/spanner_dbapi/connection.py Show resolved Hide resolved
@skuruppu skuruppu merged commit 237ae41 into googleapis:main Sep 7, 2021
11 checks passed
@IlyaFaer IlyaFaer deleted the connection_validate branch Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
3 participants