Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set a separate user agent for the DB API #566

Merged
merged 3 commits into from Sep 13, 2021
Merged

Conversation

IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Sep 9, 2021

@IlyaFaer IlyaFaer added type: feature request priority: p1 labels Sep 9, 2021
@google-cla google-cla bot added the cla: yes label Sep 9, 2021
@product-auto-label product-auto-label bot added the api: spanner label Sep 9, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review Sep 9, 2021
@IlyaFaer IlyaFaer requested a review from as a code owner Sep 9, 2021
@IlyaFaer IlyaFaer requested a review from skuruppu Sep 9, 2021
larkee
larkee approved these changes Sep 9, 2021
@larkee larkee added the kokoro:force-run label Sep 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 9, 2021
@skuruppu skuruppu added the automerge label Sep 9, 2021
@gcf-merge-on-green
Copy link
Contributor

@gcf-merge-on-green gcf-merge-on-green bot commented Sep 10, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Sep 10, 2021
@IlyaFaer IlyaFaer added the kokoro:force-run label Sep 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 10, 2021
@larkee larkee added the kokoro:force-run label Sep 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 10, 2021
@IlyaFaer
Copy link
Member Author

@IlyaFaer IlyaFaer commented Sep 10, 2021

A couple of sample tests failed with google.api_core.exceptions.RetryError: Deadline of 240.0s exceeded - doesn't seem to be related

@larkee larkee merged commit b5f977e into googleapis:main Sep 13, 2021
11 checks passed
@IlyaFaer IlyaFaer deleted the user_agent branch Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes priority: p1 type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants