Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db_api): support stale reads #584

Merged
merged 50 commits into from Nov 13, 2021
Merged

feat(db_api): support stale reads #584

merged 50 commits into from Nov 13, 2021

Conversation

IlyaFaer
Copy link
Member

@IlyaFaer IlyaFaer commented Sep 21, 2021

Based on #475 and requires it to be merged first.

IlyaFaer and others added 30 commits Aug 2, 2021
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
google/cloud/spanner_dbapi/connection.py Outdated Show resolved Hide resolved
tests/unit/spanner_dbapi/test_connection.py Outdated Show resolved Hide resolved
tests/unit/spanner_dbapi/test_connection.py Outdated Show resolved Hide resolved
@larkee larkee requested a review from as a code owner Nov 1, 2021
larkee
larkee approved these changes Nov 1, 2021
@skuruppu
Copy link
Contributor

@skuruppu skuruppu commented Nov 9, 2021

@IlyaFaer what do we need to do to get this merged? Are the test failures related to this change or are they flaky?

@IlyaFaer IlyaFaer added the kokoro:force-run label Nov 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Nov 10, 2021
@IlyaFaer
Copy link
Member Author

@IlyaFaer IlyaFaer commented Nov 10, 2021

@skuruppu, looks like there was a problem with lint (I've updated the black linting package locally, but kokoro seems to be using a particular version). Fixed it, let's see if everything is okay now.

@IlyaFaer IlyaFaer added the kokoro:force-run label Nov 11, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Nov 11, 2021
@IlyaFaer IlyaFaer merged commit 8ca868c into googleapis:main Nov 13, 2021
13 checks passed
@IlyaFaer IlyaFaer deleted the stale_reads branch Nov 13, 2021
asthamohta pushed a commit to asthamohta/python-spanner that referenced this issue Nov 16, 2021
asthamohta pushed a commit to asthamohta/python-spanner that referenced this issue Nov 16, 2021
asthamohta pushed a commit to asthamohta/python-spanner that referenced this issue Nov 16, 2021
vi3k6i5 pushed a commit that referenced this issue Dec 21, 2021
* chore: changing default region to us-west1

* chore(deps): update all dependencies (#602)

* chore: add default_version and codeowner_team to .repo-metadata.json (#641)

* feat(db_api): support stale reads (#584)

* feat: removing changes from samples

* chore: change region

* fix: fix in sample list-backups

Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Ilya Gurov <ilya.faer@mail.ru>
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
vi3k6i5 pushed a commit to vi3k6i5/python-spanner that referenced this issue Mar 29, 2022
* chore: changing default region to us-west1

* chore(deps): update all dependencies (googleapis#602)

* chore: add default_version and codeowner_team to .repo-metadata.json (googleapis#641)

* feat(db_api): support stale reads (googleapis#584)

* feat: removing changes from samples

* chore: change region

* fix: fix in sample list-backups

Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Ilya Gurov <ilya.faer@mail.ru>
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants